Commit 5737f7dc authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915/fbc: Split plane rotation checks per-platform 



Carve up rotation_is_valid() into per-platform variants to
make it easier to see what limits are actually being imposed.

TODO: maybe go for vfuncs later

Reviewed-by: default avatarJuha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: default avatarVinod Govindapillai <vinod.govindapillai@intel.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231003194256.28569-4-ville.syrjala@linux.intel.com
parent 9fbe915b

drivers/gpu/drm/i915/display/intel_fbc.c

+24 −6
Original line number Diff line number Diff line
@@ -945,22 +945,40 @@ static bool pixel_format_is_valid(const struct intel_plane_state *plane_state) 
	}

}



static bool rotation_is_valid(const struct intel_plane_state *plane_state)

static bool i8xx_fbc_rotation_is_valid(const struct intel_plane_state *plane_state)

{

	return plane_state->hw.rotation == DRM_MODE_ROTATE_0;

}



static bool g4x_fbc_rotation_is_valid(const struct intel_plane_state *plane_state)

{

	return true;

}



static bool skl_fbc_rotation_is_valid(const struct intel_plane_state *plane_state)

{

	struct drm_i915_private *i915 = to_i915(plane_state->uapi.plane->dev);

	const struct drm_framebuffer *fb = plane_state->hw.fb;

	unsigned int rotation = plane_state->hw.rotation;



	if (DISPLAY_VER(i915) >= 9 && fb->format->format == DRM_FORMAT_RGB565 &&

	if (fb->format->format == DRM_FORMAT_RGB565 &&

	    drm_rotation_90_or_270(rotation))

		return false;

	else if (DISPLAY_VER(i915) <= 4 && !IS_G4X(i915) &&

		 rotation != DRM_MODE_ROTATE_0)

		return false;



	return true;

}



static bool rotation_is_valid(const struct intel_plane_state *plane_state)

{

	struct drm_i915_private *i915 = to_i915(plane_state->uapi.plane->dev);



	if (DISPLAY_VER(i915) >= 9)

		return skl_fbc_rotation_is_valid(plane_state);

	else if (DISPLAY_VER(i915) >= 5 || IS_G4X(i915))

		return g4x_fbc_rotation_is_valid(plane_state);

	else

		return i8xx_fbc_rotation_is_valid(plane_state);

}



/*

 * For some reason, the hardware tracking starts looking at whatever we

 * programmed as the display plane base address register. It does not look at