Commit 576f0d7a authored by Azeem Shaikh's avatar Azeem Shaikh Committed by Kees Cook
Browse files

drm/rockchip: Replace all non-returning strlcpy with strscpy 

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89



Signed-off-by: default avatarAzeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230522155149.2336620-1-azeemshaikh38@gmail.com
parent 533950d3

drivers/gpu/drm/rockchip/inno_hdmi.c

+1 −1
Original line number Diff line number Diff line
@@ -797,7 +797,7 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi) 
	adap->dev.parent = hdmi->dev;

	adap->dev.of_node = hdmi->dev->of_node;

	adap->algo = &inno_hdmi_algorithm;

	strlcpy(adap->name, "Inno HDMI", sizeof(adap->name));

	strscpy(adap->name, "Inno HDMI", sizeof(adap->name));

	i2c_set_adapdata(adap, hdmi);



	ret = i2c_add_adapter(adap);

drivers/gpu/drm/rockchip/rk3066_hdmi.c

+1 −1
Original line number Diff line number Diff line
@@ -730,7 +730,7 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi) 
	adap->dev.parent = hdmi->dev;

	adap->dev.of_node = hdmi->dev->of_node;

	adap->algo = &rk3066_hdmi_algorithm;

	strlcpy(adap->name, "RK3066 HDMI", sizeof(adap->name));

	strscpy(adap->name, "RK3066 HDMI", sizeof(adap->name));

	i2c_set_adapdata(adap, hdmi);



	ret = i2c_add_adapter(adap);