Commit 577db6bd authored by Matthieu Baerts (NGI0)'s avatar Matthieu Baerts (NGI0) Committed by Jakub Kicinski
Browse files

selftests: net: lib: do not set ns var as readonly 



It sounds good to mark the global netns variable as 'readonly', but Bash
doesn't allow the creation of local variables with the same name.

Because it looks like 'readonly' is mainly used here to check if a netns
with that name has already been set, it sounds fine to check if a
variable with this name has already been set instead. By doing that, we
avoid having to modify helpers from MPTCP selftests using the same
variable name as the one used to store the created netns name.

While at it, also avoid an unnecessary call to 'eval' to set a local
variable.

Reviewed-by: default avatarGeliang Tang <geliang@kernel.org>
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://lore.kernel.org/r/20240607-upstream-net-next-20240607-selftests-mptcp-net-lib-v1-3-e36986faac94@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 92fe5670

tools/testing/selftests/net/lib.sh

+3 −3
Original line number Diff line number Diff line
@@ -172,11 +172,11 @@ setup_ns() 
	local ns_list=()

	for ns_name in "$@"; do

		# Some test may setup/remove same netns multi times

		if unset ${ns_name} 2> /dev/null; then

		if [ -z "${!ns_name}" ]; then

			ns="${ns_name,,}-$(mktemp -u XXXXXX)"

			eval readonly ${ns_name}="$ns"

			eval "${ns_name}=${ns}"

		else

			eval ns='$'${ns_name}

			ns="${!ns_name}"

			cleanup_ns "$ns"

		fi