Commit 57a217f1 authored by Rob Herring (Arm)'s avatar Rob Herring (Arm) Committed by Ulf Hansson
Browse files

mmc: Use of_property_present() for non-boolean properties 



The use of of_property_read_bool() for non-boolean properties is
deprecated in favor of of_property_present() when testing for property
presence.

Reviewed-by: default avatarHaibo Chen <haibo.chen@nxp.com>
Reviewed-by: default avatarDragan Simic <dsimic@manjaro.org>
Acked-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/all/20250109155255.3438450-1-robh@kernel.org/


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 285035a8

drivers/mmc/host/mxcmmc.c

+4 −4
Original line number Diff line number Diff line
@@ -995,7 +995,7 @@ static int mxcmci_probe(struct platform_device *pdev) 
	struct mxcmci_host *host;

	struct resource *res;

	int ret = 0, irq;

	bool dat3_card_detect = false;

	bool dat3_card_detect;

	dma_cap_mask_t mask;

	struct imxmmc_platform_data *pdata = pdev->dev.platform_data;
@@ -1048,9 +1048,9 @@ static int mxcmci_probe(struct platform_device *pdev) 


	if (pdata)

		dat3_card_detect = pdata->dat3_card_detect;

	else if (mmc_card_is_removable(mmc)

			&& !of_property_read_bool(pdev->dev.of_node, "cd-gpios"))

		dat3_card_detect = true;

	else

		dat3_card_detect = mmc_card_is_removable(mmc) &&

				   !of_property_present(pdev->dev.of_node, "cd-gpios");



	ret = mmc_regulator_get_supply(mmc);

	if (ret)

drivers/mmc/host/sdhci-esdhc-imx.c

+1 −1
Original line number Diff line number Diff line
@@ -1648,7 +1648,7 @@ sdhci_esdhc_imx_probe_dt(struct platform_device *pdev, 
	 * Retrieving and requesting the actual WP GPIO will happen

	 * in the call to mmc_of_parse().

	 */

	if (of_property_read_bool(np, "wp-gpios"))

	if (of_property_present(np, "wp-gpios"))

		boarddata->wp_type = ESDHC_WP_GPIO;



	of_property_read_u32(np, "fsl,tuning-step", &boarddata->tuning_step);