Commit 57be33f8 authored by Carl Lee's avatar Carl Lee Committed by Jakub Kicinski
Browse files

nfc: nxp-nci: remove interrupt trigger type 



For NXP NCI devices (e.g. PN7150), the interrupt is level-triggered and
active high, not edge-triggered.

Using IRQF_TRIGGER_RISING in the driver can cause interrupts to fail
to trigger correctly.

Remove IRQF_TRIGGER_RISING and rely on the IRQ trigger type configured
via Device Tree.

Signed-off-by: default avatarCarl Lee <carl.lee@amd.com>
Link: https://patch.msgid.link/20260205-fc-nxp-nci-remove-interrupt-trigger-type-v2-1-79d2ed4a7e42@amd.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 1fdad81d

drivers/nfc/nxp-nci/i2c.c

+1 −1
Original line number Diff line number Diff line
@@ -305,7 +305,7 @@ static int nxp_nci_i2c_probe(struct i2c_client *client) 


	r = request_threaded_irq(client->irq, NULL,

				 nxp_nci_i2c_irq_thread_fn,

				 IRQF_TRIGGER_RISING | IRQF_ONESHOT,

				 IRQF_ONESHOT,

				 NXP_NCI_I2C_DRIVER_NAME, phy);

	if (r < 0)

		nfc_err(&client->dev, "Unable to register IRQ handler\n");