Unverified Commit 57d508b5 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

ASoC: rockchip: Fix Wvoid-pointer-to-enum-cast warning (again) 

'version' is an enum, thus cast of pointer on 64-bit compile test with
clang W=1 causes:

  rockchip_pdm.c:583:17: error: cast to smaller integer type 'enum rk_pdm_version' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]

This was already fixed in commit 49a4a8d1 ("ASoC: rockchip: Fix
Wvoid-pointer-to-enum-cast warning") but then got bad in
commit 9958d859 ("ASoC: Use device_get_match_data()").

Discussion on LKML also pointed out that 'uintptr_t' is not the correct
type and either 'kernel_ulong_t' or 'unsigned long' should be used,
with several arguments towards the latter [1].

Link: https://lore.kernel.org/r/CAMuHMdX7t=mabqFE5O-Cii3REMuyaePHmqX+j_mqyrn6XXzsoA@mail.gmail.com/

 [1]
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20251203141644.106459-2-krzysztof.kozlowski@oss.qualcomm.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2c7e5e17

sound/soc/rockchip/rockchip_pdm.c

+1 −1
Original line number Diff line number Diff line
@@ -580,7 +580,7 @@ static int rockchip_pdm_probe(struct platform_device *pdev) 
	if (!pdm)

		return -ENOMEM;



	pdm->version = (enum rk_pdm_version)device_get_match_data(&pdev->dev);

	pdm->version = (unsigned long)device_get_match_data(&pdev->dev);

	if (pdm->version == RK_PDM_RK3308) {

		pdm->reset = devm_reset_control_get(&pdev->dev, "pdm-m");

		if (IS_ERR(pdm->reset))