Commit 57de689c authored by Florian Fainelli's avatar Florian Fainelli Committed by Marc Zyngier
Browse files

irqchip/irq-bcm7038-l1: Remove .irq_cpu_offline() 



With arch/mips/kernel/smp-bmips.c having been migrated away from
irq_cpu_offline() and use irq_migrate_all_off_this_cpu() instead, we no
longer need to implement an .irq_cpu_offline() callback. This is a
necessary change to facilitate the building of this driver as a module.

Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20211020184859.2705451-3-f.fainelli@gmail.com
parent bf8bde41

drivers/irqchip/irq-bcm7038-l1.c

+0 −30
Original line number Diff line number Diff line
@@ -221,33 +221,6 @@ static int bcm7038_l1_set_affinity(struct irq_data *d, 
	return 0;

}



#ifdef CONFIG_SMP

static void bcm7038_l1_cpu_offline(struct irq_data *d)

{

	struct cpumask *mask = irq_data_get_affinity_mask(d);

	int cpu = smp_processor_id();

	cpumask_t new_affinity;



	/* This CPU was not on the affinity mask */

	if (!cpumask_test_cpu(cpu, mask))

		return;



	if (cpumask_weight(mask) > 1) {

		/*

		 * Multiple CPU affinity, remove this CPU from the affinity

		 * mask

		 */

		cpumask_copy(&new_affinity, mask);

		cpumask_clear_cpu(cpu, &new_affinity);

	} else {

		/* Only CPU, put on the lowest online CPU */

		cpumask_clear(&new_affinity);

		cpumask_set_cpu(cpumask_first(cpu_online_mask), &new_affinity);

	}

	irq_set_affinity_locked(d, &new_affinity, false);

}

#endif



static int __init bcm7038_l1_init_one(struct device_node *dn,

				      unsigned int idx,

				      struct bcm7038_l1_chip *intc)
@@ -396,9 +369,6 @@ static struct irq_chip bcm7038_l1_irq_chip = { 
	.irq_mask		= bcm7038_l1_mask,

	.irq_unmask		= bcm7038_l1_unmask,

	.irq_set_affinity	= bcm7038_l1_set_affinity,

#ifdef CONFIG_SMP

	.irq_cpu_offline	= bcm7038_l1_cpu_offline,

#endif

#ifdef CONFIG_PM_SLEEP

	.irq_set_wake		= bcm7038_l1_set_wake,

#endif