Commit 57eb6dcd authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Tzung-Bi Shih
Browse files

platform/chrome/wilco_ec: Remove usage of the deprecated ida_simple_xx() API 



ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

This is less verbose.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/898d9aa181a84f1d17725ca047004bad532c37e9.1702745959.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent 59a9ccf1

drivers/platform/chrome/wilco_ec/event.c

+2 −2
Original line number Diff line number Diff line
@@ -495,7 +495,7 @@ static int event_device_add(struct acpi_device *adev) 
free_dev_data:

	hangup_device(dev_data);

free_minor:

	ida_simple_remove(&event_ida, minor);

	ida_free(&event_ida, minor);

	return error;

}
@@ -504,7 +504,7 @@ static void event_device_remove(struct acpi_device *adev) 
	struct event_device_data *dev_data = adev->driver_data;



	cdev_device_del(&dev_data->cdev, &dev_data->dev);

	ida_simple_remove(&event_ida, MINOR(dev_data->dev.devt));

	ida_free(&event_ida, MINOR(dev_data->dev.devt));

	hangup_device(dev_data);

}

drivers/platform/chrome/wilco_ec/telemetry.c

+3 −3
Original line number Diff line number Diff line
@@ -372,7 +372,7 @@ static int telem_device_probe(struct platform_device *pdev) 


	dev_data = kzalloc(sizeof(*dev_data), GFP_KERNEL);

	if (!dev_data) {

		ida_simple_remove(&telem_ida, minor);

		ida_free(&telem_ida, minor);

		return -ENOMEM;

	}
@@ -393,7 +393,7 @@ static int telem_device_probe(struct platform_device *pdev) 
	error = cdev_device_add(&dev_data->cdev, &dev_data->dev);

	if (error) {

		put_device(&dev_data->dev);

		ida_simple_remove(&telem_ida, minor);

		ida_free(&telem_ida, minor);

		return error;

	}
@@ -405,7 +405,7 @@ static void telem_device_remove(struct platform_device *pdev) 
	struct telem_device_data *dev_data = platform_get_drvdata(pdev);



	cdev_device_del(&dev_data->cdev, &dev_data->dev);

	ida_simple_remove(&telem_ida, MINOR(dev_data->dev.devt));

	ida_free(&telem_ida, MINOR(dev_data->dev.devt));

	put_device(&dev_data->dev);

}