Commit 57f6f479 authored by Erick Karanja's avatar Erick Karanja Committed by Guenter Roeck
Browse files

hwmon: (pmbus/isl68137) Fix child node reference leak on early return 



In the case of an early return, the reference to the child node needs
to be released.

Use for_each_child_of_node_scoped to fix the issue.

Fixes: 3996187f ("hwmon: (pmbus/isl68137) add support for voltage divider on Vout")
Signed-off-by: default avatarErick Karanja <karanja99erick@gmail.com>
Link: https://lore.kernel.org/r/20251012181249.359401-1-karanja99erick@gmail.com


[groeck: Updated subject/description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 72ac1485

drivers/hwmon/pmbus/isl68137.c

+1 −2
Original line number Diff line number Diff line
@@ -336,10 +336,9 @@ static int isl68137_probe_from_dt(struct device *dev, 
				  struct isl68137_data *data)

{

	const struct device_node *np = dev->of_node;

	struct device_node *child;

	int err;



	for_each_child_of_node(np, child) {

	for_each_child_of_node_scoped(np, child) {

		if (strcmp(child->name, "channel"))

			continue;