Commit 582ccf78 authored by SeongJae Park's avatar SeongJae Park Committed by Andrew Morton
Browse files

selftests/damon/damon_nr_regions: sort collected regiosn before checking with min/max boundaries 

damon_nr_regions.py starts DAMON, periodically collect number of regions
in snapshots, and see if it is in the requested range.  The check code
assumes the numbers are sorted on the collection list, but there is no
such guarantee.  Hence this can result in false positive test success. 
Sort the list before doing the check.

Link: https://lkml.kernel.org/r/20250225222333.505646-4-sj@kernel.org


Fixes: 78149734 ("selftests/damon: implement test for min/max_nr_regions")
Signed-off-by: default avatarSeongJae Park <sj@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 695469c0

tools/testing/selftests/damon/damon_nr_regions.py

+1 −0
Original line number Diff line number Diff line
@@ -65,6 +65,7 @@ def test_nr_regions(real_nr_regions, min_nr_regions, max_nr_regions): 


    test_name = 'nr_regions test with %d/%d/%d real/min/max nr_regions' % (

            real_nr_regions, min_nr_regions, max_nr_regions)

    collected_nr_regions.sort()

    if (collected_nr_regions[0] < min_nr_regions or

        collected_nr_regions[-1] > max_nr_regions):

        print('fail %s' % test_name)