Commit 58409f0d authored by Leon Romanovsky's avatar Leon Romanovsky
Browse files

RDMA/mlx4: Remove unused create_flags field from CQ structure 

The CQ creation flags do not need to be cached, as they are used
immediately at the point where they are stored. Remove the unused
field and reclaim 4 bytes.

Link: https://patch.msgid.link/20260213-refactor-umem-v1-14-f3be85847922@nvidia.com


Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
parent f45f195a

drivers/infiniband/hw/mlx4/cq.c

+1 −3
Original line number Diff line number Diff line
@@ -165,7 +165,6 @@ int mlx4_ib_create_user_cq(struct ib_cq *ibcq, 
	cq->ibcq.cqe = entries - 1;

	mutex_init(&cq->resize_mutex);

	spin_lock_init(&cq->lock);

	cq->create_flags = attr->flags;

	INIT_LIST_HEAD(&cq->send_qp_list);

	INIT_LIST_HEAD(&cq->recv_qp_list);
@@ -208,8 +207,7 @@ int mlx4_ib_create_user_cq(struct ib_cq *ibcq, 


	err = mlx4_cq_alloc(dev->dev, entries, &cq->buf.mtt, &context->uar,

			    cq->db.dma, &cq->mcq, vector, 0,

			    !!(cq->create_flags &

			       IB_UVERBS_CQ_FLAGS_TIMESTAMP_COMPLETION),

			    attr->flags & IB_UVERBS_CQ_FLAGS_TIMESTAMP_COMPLETION,

			    buf_addr, true);

	if (err)

		goto err_dbmap;

drivers/infiniband/hw/mlx4/mlx4_ib.h

+0 −1
Original line number Diff line number Diff line
@@ -122,7 +122,6 @@ struct mlx4_ib_cq { 
	spinlock_t		lock;

	struct mutex		resize_mutex;

	struct ib_umem	       *resize_umem;

	int			create_flags;

	/* List of qps that it serves.*/

	struct list_head		send_qp_list;

	struct list_head		recv_qp_list;