Commit 585a4f22 authored by Vincent Mailhol's avatar Vincent Mailhol Committed by Marc Kleine-Budde
Browse files

can: bittiming: apply NL_SET_ERR_MSG() to can_calc_bittiming() 



When CONFIG_CAN_CALC_BITTIMING is disabled, the can_calc_bittiming()
functions can not be used and the user needs to provide all the
bittiming parameters.

Currently, can_calc_bittiming() prints an error message to the kernel
log. Instead use NL_SET_ERR_MSG() to make it return the error message
through the netlink interface so that the user can directly see it.

Signed-off-by: default avatarVincent Mailhol <mailhol@kernel.org>
Signed-off-by: default avatarOliver Hartkopp <socketcan@hartkopp.net>
Link: https://patch.msgid.link/20251126-canxl-v8-2-e7e3eb74f889@pengutronix.de


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 66e75b27

include/linux/can/bittiming.h

+1 −1
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ static inline int 
can_calc_bittiming(const struct net_device *dev, struct can_bittiming *bt,

		   const struct can_bittiming_const *btc, struct netlink_ext_ack *extack)

{

	netdev_err(dev, "bit-timing calculation not available\n");

	NL_SET_ERR_MSG(extack, "bit-timing calculation not available\n");

	return -EINVAL;

}