Commit 587371ed authored by Damien Le Moal's avatar Damien Le Moal Committed by Jens Axboe
Browse files

block: Treat sequential write preferred zone type as invalid 



With the removal of the support for host-aware zoned devices,
blk_revalidate_zone_cb() should never see the zone type
BLK_ZONE_TYPE_SEQWRITE_PREF (sequential write preffered zones). Treat
this zone type as being invalid.

Fixes: 7437bb73 ("block: remove support for the host aware zone model")
Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20240107072212.1071080-1-dlemoal@kernel.org


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 4e33b071

block/blk-zoned.c

+1 −1
Original line number Diff line number Diff line
@@ -498,7 +498,6 @@ static int blk_revalidate_zone_cb(struct blk_zone *zone, unsigned int idx, 
		set_bit(idx, args->conv_zones_bitmap);

		break;

	case BLK_ZONE_TYPE_SEQWRITE_REQ:

	case BLK_ZONE_TYPE_SEQWRITE_PREF:

		if (!args->seq_zones_wlock) {

			args->seq_zones_wlock =

				blk_alloc_zone_bitmap(q->node, args->nr_zones);
@@ -506,6 +505,7 @@ static int blk_revalidate_zone_cb(struct blk_zone *zone, unsigned int idx, 
				return -ENOMEM;

		}

		break;

	case BLK_ZONE_TYPE_SEQWRITE_PREF:

	default:

		pr_warn("%s: Invalid zone type 0x%x at sectors %llu\n",

			disk->disk_name, (int)zone->type, zone->start);