Unverified Commit 589996bf authored by Diogo Jahchan Koike's avatar Diogo Jahchan Koike Committed by Konstantin Komarov
Browse files

ntfs3: Change to non-blocking allocation in ntfs_d_hash 



d_hash is done while under "rcu-walk" and should not sleep.
__get_name() allocates using GFP_KERNEL, having the possibility
to sleep when under memory pressure. Change the allocation to
GFP_NOWAIT.

Reported-by: default avatar <syzbot+7f71f79bbfb4427b00e1@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=7f71f79bbfb4427b00e1


Fixes: d392e85f ("fs/ntfs3: Fix the format of the "nocase" mount option")
Signed-off-by: default avatarDiogo Jahchan Koike <djahchankoike@gmail.com>
Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
parent bdd6baf7

fs/ntfs3/namei.c

+2 −2
Original line number Diff line number Diff line
@@ -395,7 +395,7 @@ static int ntfs_d_hash(const struct dentry *dentry, struct qstr *name) 
	/*

	 * Try slow way with current upcase table

	 */

	uni = __getname();

	uni = kmem_cache_alloc(names_cachep, GFP_NOWAIT);

	if (!uni)

		return -ENOMEM;
@@ -417,7 +417,7 @@ static int ntfs_d_hash(const struct dentry *dentry, struct qstr *name) 
	err = 0;



out:

	__putname(uni);

	kmem_cache_free(names_cachep, uni);

	return err;

}