Commit 590b1d19 authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: max31335: remove unecessary locking 



There is no race condition when accessing MAX31335_STATUS1 because it is
always about clearing the alarm interrupt bit.

Reviewed-by: default avatarAntoniu Miclaus <antoniu.miclaus@analog.com>
Link: https://lore.kernel.org/r/20240115232215.273374-1-alexandre.belloni@bootlin.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent dedaf03b

drivers/rtc/rtc-max31335.c

+3 −11
Original line number Diff line number Diff line
@@ -348,27 +348,19 @@ static int max31335_alarm_irq_enable(struct device *dev, unsigned int enabled) 
static irqreturn_t max31335_handle_irq(int irq, void *dev_id)

{

	struct max31335_data *max31335 = dev_id;

	struct mutex *lock = &max31335->rtc->ops_lock;

	int ret, status;



	mutex_lock(lock);



	ret = regmap_read(max31335->regmap, MAX31335_STATUS1, &status);

	if (ret)

		goto exit;

		return IRQ_HANDLED;



	if (FIELD_GET(MAX31335_STATUS1_A1F, status)) {

		ret = regmap_update_bits(max31335->regmap, MAX31335_STATUS1,

		regmap_update_bits(max31335->regmap, MAX31335_STATUS1,

				   MAX31335_STATUS1_A1F, 0);

		if (ret)

			goto exit;



		rtc_update_irq(max31335->rtc, 1, RTC_AF | RTC_IRQF);

	}



exit:

	mutex_unlock(lock);



	return IRQ_HANDLED;

}