Commit 592975da authored by Wilfred Mallawa's avatar Wilfred Mallawa Committed by Carlos Maiolino
Browse files

xfs: fix memory leak on error in xfs_alloc_zone_info() 



Currently, the 0th index of the zi_used_bucket_bitmap array is not freed
on error due to the pre-decrement then evaluate semantic of the while
loop used in xfs_alloc_zone_info(). Fix it by allowing for the i == 0
case to be covered.

Fixes: 080d01c4 ("xfs: implement zoned garbage collection")
Cc: stable@vger.kernel.org # v6.15
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: default avatarWilfred Mallawa <wilfred.mallawa@wdc.com>
Reviewed-by: default avatarHans Holmberg <hans.holmberg@wdc.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent 939919cc

fs/xfs/xfs_zone_alloc.c

+1 −1
Original line number Diff line number Diff line
@@ -1217,7 +1217,7 @@ xfs_alloc_zone_info( 
	return zi;



out_free_bitmaps:

	while (--i > 0)

	while (--i >= 0)

		kvfree(zi->zi_used_bucket_bitmap[i]);

	kfree(zi);

	return NULL;