Commit 59297e20 authored by Harshit Agarwal's avatar Harshit Agarwal Committed by Peter Zijlstra
Browse files

sched: add READ_ONCE to task_on_rq_queued 



task_on_rq_queued read p->on_rq without READ_ONCE, though p->on_rq is
set with WRITE_ONCE in {activate|deactivate}_task and smp_store_release
in __block_task, and also read with READ_ONCE in task_on_rq_migrating.

Make all of these accesses pair together by adding READ_ONCE in the
task_on_rq_queued.

Signed-off-by: default avatarHarshit Agarwal <harshit@nutanix.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarPhil Auld <pauld@redhat.com>
Link: https://lkml.kernel.org/r/20241114210812.1836587-1-jon@nutanix.com
parent 108ad099

kernel/sched/sched.h

+1 −1
Original line number Diff line number Diff line
@@ -2271,7 +2271,7 @@ static inline int task_on_cpu(struct rq *rq, struct task_struct *p) 


static inline int task_on_rq_queued(struct task_struct *p)

{

	return p->on_rq == TASK_ON_RQ_QUEUED;

	return READ_ONCE(p->on_rq) == TASK_ON_RQ_QUEUED;

}



static inline int task_on_rq_migrating(struct task_struct *p)