Commit 592d1c23 authored by wangdicheng's avatar wangdicheng Committed by Takashi Iwai
Browse files

ALSA: hda/senary: Replace magic numbers with defined constants 



Replace hardcoded GPIO node value with a defined constant for better
code readability and maintainability.

Signed-off-by: default avatarwangdicheng <wangdicheng@kylinos.cn>
Link: https://patch.msgid.link/20251107024030.36712-1-wangdich9700@163.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 79d062bd

sound/hda/codecs/senarytech.c

+6 −3
Original line number Diff line number Diff line
@@ -19,6 +19,9 @@ 
#include "hda_jack.h"

#include "generic.h"



/* GPIO node ID */

#define SENARY_GPIO_NODE	0x01



struct senary_spec {

	struct hda_gen_spec gen;
@@ -120,11 +123,11 @@ static void senary_init_gpio_led(struct hda_codec *codec) 
	unsigned int mask = spec->gpio_mute_led_mask | spec->gpio_mic_led_mask;



	if (mask) {

		snd_hda_codec_write(codec, 0x01, 0, AC_VERB_SET_GPIO_MASK,

		snd_hda_codec_write(codec, SENARY_GPIO_NODE, 0, AC_VERB_SET_GPIO_MASK,

				    mask);

		snd_hda_codec_write(codec, 0x01, 0, AC_VERB_SET_GPIO_DIRECTION,

		snd_hda_codec_write(codec, SENARY_GPIO_NODE, 0, AC_VERB_SET_GPIO_DIRECTION,

				    mask);

		snd_hda_codec_write(codec, 0x01, 0, AC_VERB_SET_GPIO_DATA,

		snd_hda_codec_write(codec, SENARY_GPIO_NODE, 0, AC_VERB_SET_GPIO_DATA,

				    spec->gpio_led);

	}

}