Commit 593062f6 authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

btrfs: unfold transaction abort at btrfs_insert_one_raid_extent() 



We have a common error path where we abort the transaction, but like this
in case we get a transaction abort stack trace we don't know exactly which
previous function call failed. Instead abort the transaction after any
function call that returns an error, so that we can easily identify which
function failed.

Reviewed-by: default avatarDaniel Vacek <neelx@suse.com>
Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 35bb03e5

fs/btrfs/raid-stripe-tree.c

+5 −2
Original line number Diff line number Diff line
@@ -329,11 +329,14 @@ int btrfs_insert_one_raid_extent(struct btrfs_trans_handle *trans, 


	ret = btrfs_insert_item(trans, stripe_root, &stripe_key, stripe_extent,

				item_size);

	if (ret == -EEXIST)

	if (ret == -EEXIST) {

		ret = update_raid_extent_item(trans, &stripe_key, stripe_extent,

					      item_size);

		if (ret)

			btrfs_abort_transaction(trans, ret);

	} else if (ret) {

		btrfs_abort_transaction(trans, ret);

	}



	kfree(stripe_extent);