Commit 595572aa authored by Lu Baolu's avatar Lu Baolu Committed by Jason Gunthorpe
Browse files

iommufd: Fix error pointer checking 

Smatch static checker reported below warning:

    drivers/iommu/iommufd/fault.c:131 iommufd_device_get_attach_handle()
    warn: 'handle' is an error pointer or valid

Fix it by checking 'handle' with IS_ERR().

Fixes: b7d88336 ("iommufd: Fault-capable hwpt attach/detach/replace")
Link: https://lore.kernel.org/r/20240712025819.63147-1-baolu.lu@linux.intel.com


Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-iommu/8bb4f37a-4514-4dea-aabb-7380be303895@stanley.mountain/


Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent d73cf5ff

drivers/iommu/iommufd/fault.c

+1 −1
Original line number Diff line number Diff line
@@ -128,7 +128,7 @@ iommufd_device_get_attach_handle(struct iommufd_device *idev) 
	struct iommu_attach_handle *handle;



	handle = iommu_attach_handle_get(idev->igroup->group, IOMMU_NO_PASID, 0);

	if (!handle)

	if (IS_ERR(handle))

		return NULL;



	return to_iommufd_handle(handle);