Commit 595ad7a3 authored by Dragan Simic's avatar Dragan Simic Committed by Vinod Koul
Browse files

phy: phy-rockchip-inno-usb2: Handle failed extcon allocation better 



Return the actual error code upon failure to allocate extcon device, instead
of hardcoding -ENOMEM.  Use dev_err_probe() to also log appropriate messages,
which is fine because the containing function is used in the probe path.

Helped-by: default avatarHeiko Stubner <heiko@sntech.de>
Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarDragan Simic <dsimic@manjaro.org>
Link: https://lore.kernel.org/r/cc4995aa3e569be6bc23ca126b41fba82d50eeee.1725524802.git.dsimic@manjaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 449d2a52

drivers/phy/rockchip/phy-rockchip-inno-usb2.c

+2 −1
Original line number Diff line number Diff line
@@ -435,7 +435,8 @@ static int rockchip_usb2phy_extcon_register(struct rockchip_usb2phy *rphy) 
						rockchip_usb2phy_extcon_cable);



		if (IS_ERR(edev))

			return -ENOMEM;

			return dev_err_probe(rphy->dev, PTR_ERR(edev),

					     "failed to allocate extcon device\n");



		ret = devm_extcon_dev_register(rphy->dev, edev);

		if (ret) {