Commit 595d7ebe authored by Joanne Koong's avatar Joanne Koong Committed by Linus Torvalds
Browse files

fuse: remove page alignment check for writeback len 



Remove incorrect page alignment check for the writeback len arg in
fuse_iomap_writeback_range().  len will always be block-aligned as
passed in by iomap.

On regular fuse filesystems, i_blkbits is set to PAGE_SHIFT so this is
not a problem but for fuseblk filesystems, the block size is set to a
default of 512 bytes or a block size passed in at mount time.

Please note that non-page-aligned lengths are fine for the logic in
fuse_iomap_writeback_range().  The check was originally added as a
safeguard to detect conspicuously wrong ranges.

Signed-off-by: default avatarJoanne Koong <joannelkoong@gmail.com>
Fixes: ef7e7cbb ("fuse: use iomap for writeback")
Reported-by: default avatarLinux Kernel Functional Testing <lkft@linaro.org>
Link: https://lore.kernel.org/linux-fsdevel/CA+G9fYs5AdVM-T2Tf3LciNCwLZEHetcnSkHsjZajVwwpM2HmJw@mail.gmail.com/


Reported-by: default avatarSasha Levin <sashal@kernel.org>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b5d760d5

fs/fuse/file.c

+0 −2
Original line number Diff line number Diff line
@@ -2154,8 +2154,6 @@ static ssize_t fuse_iomap_writeback_range(struct iomap_writepage_ctx *wpc, 
	loff_t offset = offset_in_folio(folio, pos);



	WARN_ON_ONCE(!data);

	/* len will always be page aligned */

	WARN_ON_ONCE(len & (PAGE_SIZE - 1));



	if (!data->ff) {

		data->ff = fuse_write_file_get(fi);