Commit 596c6963 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

Revert "r8169: add DASH support for RTL8127AP"



This reverts commit 17e9f841.

Nathan reports error messages appearing in dmesg since commit
under Fixes:

  [    3.844125] r8169 0000:01:00.0 (unnamed net_device) (uninitialized): rtl_eriar_cond == 0 (loop: 100, delay: 100).
  [    3.864844] r8169 0000:01:00.0 eth0: rtl_eriar_cond == 1 (loop: 100, delay: 100).
  [    3.878825] r8169 0000:01:00.0 eth0: rtl_eriar_cond == 1 (loop: 100, delay: 100).
  [    3.892632] r8169 0000:01:00.0 eth0: rtl_eriar_cond == 1 (loop: 100, delay: 100).
  [    5.002551] r8169 0000:01:00.0 eth0: rtl_eriar_cond == 1 (loop: 100, delay: 100).
  [    5.016286] r8169 0000:01:00.0 eth0: rtl_eriar_cond == 1 (loop: 100, delay: 100).
  [    5.030027] r8169 0000:01:00.0 eth0: rtl_eriar_cond == 1 (loop: 100, delay: 100).

Let's drop the bad change and revisit in the next release cycle.

Repoted-by: default avatarNathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/20251201224238.GA604467@ax162


Fixes: 17e9f841 ("r8169: add DASH support for RTL8127AP")
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8d92057c
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
@@ -1512,7 +1512,6 @@ static enum rtl_dash_type rtl_get_dash_type(struct rtl8169_private *tp)
	case RTL_GIGA_MAC_VER_51 ... RTL_GIGA_MAC_VER_52:
		return RTL_DASH_EP;
	case RTL_GIGA_MAC_VER_66:
	case RTL_GIGA_MAC_VER_80:
		return RTL_DASH_25_BP;
	default:
		return RTL_DASH_NONE;