Commit 597b3627 authored Mar 05, 2025 by Bartosz Golaszewski Committed by Linus Walleij Mar 14, 2025

pinctrl: spacemit: destroy mutex at driver detach



The mutex initialized in probe() is never cleaned up. Use
devm_mutex_init() to destroy it automatically.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Yixun Lan <dlan@gentoo.org>
Link: https://lore.kernel.org/20250305102710.52762-1-brgl@bgdev.pl


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 8171e7b9

drivers/pinctrl/spacemit/pinctrl-k1.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -9,6 +9,7 @@
		#include <linux/seq_file.h>
		#include <linux/spinlock.h>
		#include <linux/module.h>
		#include <linux/mutex.h>

		#include <linux/pinctrl/pinconf-generic.h>
		#include <linux/pinctrl/pinconf.h>
		@@ -749,7 +750,10 @@ static int spacemit_pinctrl_probe(struct platform_device *pdev)
		pctrl->data = pctrl_data;
		pctrl->dev = dev;
		raw_spin_lock_init(&pctrl->lock);
		mutex_init(&pctrl->mutex);

		ret = devm_mutex_init(dev, &pctrl->mutex);
		if (ret)
		return ret;

		platform_set_drvdata(pdev, pctrl);