Commit 59a0ab49 authored by Shashank Gupta's avatar Shashank Gupta Committed by Herbert Xu
Browse files

crypto: qat - delay sysfs initialization 



The function adf_sysfs_init() is used by qat_4xxx to create sysfs
attributes. This is called by the probe function before starting a
device. With this sequence, there might be a chance that the sysfs
entries for configuration might be changed by a user while the driver
is performing a device bring-up causing unexpected behaviors.

Delay the creation of sysfs entries after adf_dev_start().

Signed-off-by: default avatarShashank Gupta <shashank.gupta@intel.com>
Reviewed-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent f900fde2

drivers/crypto/qat/qat_4xxx/adf_drv.c

+4 −4
Original line number Diff line number Diff line
@@ -411,10 +411,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
		goto out_err_disable_aer;

	}



	ret = adf_sysfs_init(accel_dev);

	if (ret)

		goto out_err_disable_aer;



	ret = hw_data->dev_config(accel_dev);

	if (ret)

		goto out_err_disable_aer;
@@ -427,6 +423,10 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	if (ret)

		goto out_err_dev_stop;



	ret = adf_sysfs_init(accel_dev);

	if (ret)

		goto out_err_dev_stop;



	return ret;



out_err_dev_stop: