Commit 59a61e69 authored by Yang Yingliang's avatar Yang Yingliang Committed by Alexandre Belloni
Browse files

i3c: master: svc: drop free_irq of devm_request_irq allocated irq 



irq allocated with devm_request_irq() will be freed in devm_irq_release(),
using free_irq() in ->remove() will causes a dangling pointer, and a
subsequent double free. So remove the free_irq() in svc_i3c_master_remove().

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20210602084935.3977636-1-yangyingliang@huawei.com
parent 6efb943b

drivers/i3c/master/svc-i3c-master.c

+0 −1
Original line number Diff line number Diff line
@@ -1448,7 +1448,6 @@ static int svc_i3c_master_remove(struct platform_device *pdev) 
	if (ret)

		return ret;



	free_irq(master->irq, master);

	clk_disable_unprepare(master->pclk);

	clk_disable_unprepare(master->fclk);

	clk_disable_unprepare(master->sclk);