Unverified Commit 59d237c8 authored by Karthik Poosa's avatar Karthik Poosa Committed by Rodrigo Vivi
Browse files

drm/xe/hwmon: Fix WRITE_I1 param from u32 to u16 



WRITE_I1 sub-command of the POWER_SETUP pcode command accepts a u16
parameter instead of u32. This change prevents potential illegal
sub-command errors.

v2: Mask uval instead of changing the prototype. (Badal)

v3: Rephrase commit message. (Badal)

Signed-off-by: default avatarKarthik Poosa <karthik.poosa@intel.com>
Fixes: 92d44a42 ("drm/xe/hwmon: Expose card reactive critical power")
Reviewed-by: default avatarBadal Nilawar <badal.nilawar@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240827155301.183383-1-karthik.poosa@intel.com


Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit a7f65709)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 1eb52589

drivers/gpu/drm/xe/xe_hwmon.c

+1 −1
Original line number Diff line number Diff line
@@ -450,7 +450,7 @@ static int xe_hwmon_pcode_write_i1(struct xe_gt *gt, u32 uval) 
{

	return xe_pcode_write(gt, PCODE_MBOX(PCODE_POWER_SETUP,

			      POWER_SETUP_SUBCOMMAND_WRITE_I1, 0),

			      uval);

			      (uval & POWER_SETUP_I1_DATA_MASK));

}



static int xe_hwmon_power_curr_crit_read(struct xe_hwmon *hwmon, int channel,