Commit 5a062c3c authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Walleij
Browse files

pinctrl: tegra: Fix off by one in tegra_pinctrl_get_group() 



This should be >= pmx->soc->ngroups instead of > to avoid an out of
bounds access.  The pmx->soc->groups[] array is allocated in
tegra_pinctrl_probe().

Fixes: c12bfa0f ("pinctrl-tegra: Restore SFSEL bit when freeing pins")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarKunwu Chan <kunwu.chan@linux.dev>
Link: https://lore.kernel.org/82b40d9d-b437-42a9-9eb3-2328aa6877ac@stanley.mountain


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 813b1a1a

drivers/pinctrl/tegra/pinctrl-tegra.c

+1 −1
Original line number Diff line number Diff line
@@ -306,7 +306,7 @@ static const struct tegra_pingroup *tegra_pinctrl_get_group(struct pinctrl_dev * 
{

	struct tegra_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);



	if (group_index < 0 || group_index > pmx->soc->ngroups)

	if (group_index < 0 || group_index >= pmx->soc->ngroups)

		return NULL;



	return &pmx->soc->groups[group_index];