Commit 5a174580 authored by Dmitry Antipov's avatar Dmitry Antipov Committed by Kalle Valo
Browse files

wifi: rt2x00: remove useless code in rt2x00queue_create_tx_descriptor() 



In 'rt2x00queue_create_tx_descriptor()', there is no need to call
'ieee80211_get_rts_cts_rate()' while checking for RTS/CTS frame
since this function returns NULL or pointer to internal bitrate
table entry, and the return value is not actually used. Compile
tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: default avatarDmitry Antipov <dmantipov@yandex.ru>
Acked-by: default avatarStanislaw Gruszka <stf_xl@wp.pl>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20231213051449.126963-1-dmantipov@yandex.ru
parent 48fa9b61

drivers/net/wireless/ralink/rt2x00/rt2x00queue.c

+0 −3
Original line number Diff line number Diff line
@@ -416,9 +416,6 @@ static void rt2x00queue_create_tx_descriptor(struct rt2x00_dev *rt2x00dev, 
			__set_bit(ENTRY_TXD_RTS_FRAME, &txdesc->flags);

		else

			__set_bit(ENTRY_TXD_CTS_FRAME, &txdesc->flags);

		if (tx_info->control.rts_cts_rate_idx >= 0)

			rate =

			    ieee80211_get_rts_cts_rate(rt2x00dev->hw, tx_info);

	}



	/*