Commit 5a37f08d authored by Jani Nikula's avatar Jani Nikula
Browse files

drm/i915/pch: use intel_de_wait_custom() instead of wait_for_us() 



Prefer the register read specific wait function over i915 wait_for_us().

Reviewed-by: default avatarGustavo Sousa <gustavo.sousa@intel.com>
Link: https://lore.kernel.org/r/67e0afa2c0c5ad39b9108af15d0496394e674518.1753956266.git.jani.nikula@intel.com


Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent 6d13a797

drivers/gpu/drm/i915/display/intel_pch_refclk.c

+10 −4
Original line number Diff line number Diff line
@@ -17,16 +17,22 @@ 


static void lpt_fdi_reset_mphy(struct intel_display *display)

{

	int ret;



	intel_de_rmw(display, SOUTH_CHICKEN2, 0, FDI_MPHY_IOSFSB_RESET_CTL);



	if (wait_for_us(intel_de_read(display, SOUTH_CHICKEN2) &

			FDI_MPHY_IOSFSB_RESET_STATUS, 100))

	ret = intel_de_wait_custom(display, SOUTH_CHICKEN2,

				   FDI_MPHY_IOSFSB_RESET_STATUS, FDI_MPHY_IOSFSB_RESET_STATUS,

				   100, 0, NULL);

	if (ret)

		drm_err(display->drm, "FDI mPHY reset assert timeout\n");



	intel_de_rmw(display, SOUTH_CHICKEN2, FDI_MPHY_IOSFSB_RESET_CTL, 0);



	if (wait_for_us((intel_de_read(display, SOUTH_CHICKEN2) &

			 FDI_MPHY_IOSFSB_RESET_STATUS) == 0, 100))

	ret = intel_de_wait_custom(display, SOUTH_CHICKEN2,

				   FDI_MPHY_IOSFSB_RESET_STATUS, 0,

				   100, 0, NULL);

	if (ret)

		drm_err(display->drm, "FDI mPHY reset de-assert timeout\n");

}