Commit 5a42b348 authored by Tony Krowiak's avatar Tony Krowiak Committed by Heiko Carstens
Browse files

s390/vfio_ap: verify ZAPQ completion after return of response code zero 



Verification that the asynchronous ZAPQ function has completed only needs
to be done when the response code indicates the function was successfully
initiated; so, let's call the apq_reset_check function immediately after
the response code zero is returned from the ZAPQ.

Signed-off-by: default avatarTony Krowiak <akrowiak@linux.ibm.com>
Reviewed-by: default avatarJason J. Herne <jjherne@linux.ibm.com>
Reviewed-by: default avatarHarald Freudenberger <freude@linux.ibm.com>
Link: https://lore.kernel.org/r/20230118203111.529766-5-akrowiak@linux.ibm.com


Signed-off-by: default avatarChristian Borntraeger <borntraeger@linux.ibm.com>
Signed-off-by: default avatarHeiko Carstens <hca@linux.ibm.com>
parent 3ba41768

drivers/s390/crypto/vfio_ap_ops.c

+3 −4
Original line number Diff line number Diff line
@@ -1656,6 +1656,9 @@ static int vfio_ap_mdev_reset_queue(struct vfio_ap_queue *q) 
	switch (status.response_code) {

	case AP_RESPONSE_NORMAL:

		ret = 0;

		/* if the reset has not completed, wait for it to take effect */

		if (!status.queue_empty || status.irq_enabled)

			ret = apq_reset_check(q);

		break;

	case AP_RESPONSE_RESET_IN_PROGRESS:

		/*
@@ -1685,10 +1688,6 @@ static int vfio_ap_mdev_reset_queue(struct vfio_ap_queue *q) 
		return -EIO;

	}



	/* wait for the reset to take effect */

	if (!(status.queue_empty && !status.irq_enabled))

		ret = apq_reset_check(q);



free_resources:

	vfio_ap_free_aqic_resources(q);