Commit 5a43d935 authored by Caleb Sander Mateos's avatar Caleb Sander Mateos Committed by Jens Axboe
Browse files

ublk: remove misleading "ubq" in "ubq_complete_io_cmd()" 



ubq_complete_io_cmd() doesn't interact with a ublk queue, so "ubq" in
the name is confusing. Most likely "ubq" was meant to be "ublk".

Signed-off-by: default avatarCaleb Sander Mateos <csander@purestorage.com>
Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20250430225234.2676781-4-csander@purestorage.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 80c0789a

drivers/block/ublk_drv.c

+5 −4
Original line number Diff line number Diff line
@@ -1125,7 +1125,7 @@ static void ublk_complete_rq(struct kref *ref) 
	__ublk_complete_rq(req);

}



static void ubq_complete_io_cmd(struct ublk_io *io, int res,

static void ublk_complete_io_cmd(struct ublk_io *io, int res,

				 unsigned issue_flags)

{

	/* mark this cmd owned by ublksrv */
@@ -1190,7 +1190,8 @@ static void ublk_dispatch_req(struct ublk_queue *ubq, 
			pr_devel("%s: need get data. op %d, qid %d tag %d io_flags %x\n",

					__func__, io->cmd->cmd_op, ubq->q_id,

					req->tag, io->flags);

			ubq_complete_io_cmd(io, UBLK_IO_RES_NEED_GET_DATA, issue_flags);

			ublk_complete_io_cmd(io, UBLK_IO_RES_NEED_GET_DATA,

					     issue_flags);

			return;

		}

		/*
@@ -1229,7 +1230,7 @@ static void ublk_dispatch_req(struct ublk_queue *ubq, 
	}



	ublk_init_req_ref(ubq, req);

	ubq_complete_io_cmd(io, UBLK_IO_RES_OK, issue_flags);

	ublk_complete_io_cmd(io, UBLK_IO_RES_OK, issue_flags);

}



static void ublk_cmd_tw_cb(struct io_uring_cmd *cmd,