Commit 5a58ac9b authored Jul 02, 2025 by Maurizio Lombardi Committed by Christoph Hellwig Jul 17, 2025

nvme-tcp: log TLS handshake failures at error level



Update the nvme_tcp_start_tls() function to use dev_err() instead of
dev_dbg() when a TLS error is detected. This ensures that handshake
failures are visible by default, aiding in debugging.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Laurence Oberman <loberman@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 3be8ad8c

drivers/nvme/host/tcp.c

+8 −3

Original line number	Diff line number	Diff line
		@@ -1745,9 +1745,14 @@ static int nvme_tcp_start_tls(struct nvme_ctrl *nctrl,
		qid, ret);
		tls_handshake_cancel(queue->sock->sk);
		} else {
		dev_dbg(nctrl->device,
		if (queue->tls_err) {
		dev_err(nctrl->device,
		"queue %d: TLS handshake complete, error %d\n",
		qid, queue->tls_err);
		} else {
		dev_dbg(nctrl->device,
		"queue %d: TLS handshake complete\n", qid);
		}
		ret = queue->tls_err;
		}
		return ret;