Commit 5a5ecedc authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Linus Walleij
Browse files

dt-bindings: pinctrl: qcom: create common LPASS LPI schema 



Just like regular TLMM pin controllers in Qualcomm SoCs, the Low Power
Audio SubSystem (LPASS) Low Power Island (LPI) TLMM blocks share a lot
of properties, so common part can be moved to separate schema to reduce
code duplication and make reviewing easier.

Except the move of common part, this introduces effective changes:
1. To all LPASS LPI bindings: Reference pinmux-node.yaml in each pin
   muxing and configuration node, to bring definition of "function" and
   "pins" properties.

2. qcom,sc7280-lpass-lpi-pinctrl: Reference pinctrl.yaml in top leve.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20231208215534.195854-1-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent fa7b1fe2

Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-common.yaml

0 → 100644
+75 −0
Original line number Diff line number Diff line 
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

%YAML 1.2

---

$id: http://devicetree.org/schemas/pinctrl/qcom,lpass-lpi-common.yaml#

$schema: http://devicetree.org/meta-schemas/core.yaml#



title: Qualcomm SoC LPASS LPI TLMM Common Properties



maintainers:

  - Bjorn Andersson <andersson@kernel.org>

  - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

  - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>



description:

  Common properties for the Top Level Mode Multiplexer pin controllers in the

  Low Power Audio SubSystem (LPASS) Low Power Island (LPI) of Qualcomm SoCs.



properties:

  gpio-controller: true



  "#gpio-cells":

    description:

      Specifying the pin number and flags, as defined in

      include/dt-bindings/gpio/gpio.h

    const: 2



  gpio-ranges:

    maxItems: 1



required:

  - gpio-controller

  - "#gpio-cells"

  - gpio-ranges



allOf:

  - $ref: pinctrl.yaml#



additionalProperties: true



$defs:

  qcom-tlmm-state:

    properties:

      drive-strength:

        enum: [2, 4, 6, 8, 10, 12, 14, 16]

        default: 2

        description:

          Selects the drive strength for the specified pins, in mA.



      slew-rate:

        enum: [0, 1, 2, 3]

        default: 0

        description: |

          0: No adjustments

          1: Higher Slew rate (faster edges)

          2: Lower Slew rate (slower edges)

          3: Reserved (No adjustments)



      bias-bus-hold: true

      bias-pull-down: true

      bias-pull-up: true

      bias-disable: true

      input-enable: true

      output-high: true

      output-low: true



    required:

      - pins

      - function



    allOf:

      - $ref: pincfg-node.yaml#

      - $ref: pinmux-node.yaml#



    additionalProperties: true

Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml

+6 −43
Original line number Diff line number Diff line
@@ -20,16 +20,6 @@ properties: 
  reg:

    maxItems: 2



  gpio-controller: true



  "#gpio-cells":

    description: Specifying the pin number and flags, as defined in

      include/dt-bindings/gpio/gpio.h

    const: 2



  gpio-ranges:

    maxItems: 1



patternProperties:

  "-state$":

    oneOf:
@@ -45,7 +35,8 @@ $defs: 
    description:

      Pinctrl node's client devices use subnodes for desired pin configuration.

      Client device subnodes use below standard properties.

    $ref: /schemas/pinctrl/pincfg-node.yaml

    $ref: qcom,lpass-lpi-common.yaml#/$defs/qcom-tlmm-state

    unevaluatedProperties: false



    properties:

      pins:
@@ -68,42 +59,14 @@ $defs: 
          Specify the alternative function to be configured for the specified

          pins.



      drive-strength:

        enum: [2, 4, 6, 8, 10, 12, 14, 16]

        default: 2

        description:

          Selects the drive strength for the specified pins, in mA.



      slew-rate:

        enum: [0, 1, 2, 3]

        default: 0

        description: |

            0: No adjustments

            1: Higher Slew rate (faster edges)

            2: Lower Slew rate (slower edges)

            3: Reserved (No adjustments)



      bias-pull-down: true

      bias-pull-up: true

      bias-bus-hold: true

      bias-disable: true

      output-high: true

      output-low: true



    required:

      - pins

      - function



    additionalProperties: false



required:

  - compatible

  - reg

  - gpio-controller

  - "#gpio-cells"

  - gpio-ranges



additionalProperties: false

allOf:

  - $ref: qcom,lpass-lpi-common.yaml#



unevaluatedProperties: false



examples:

  - |

Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml

+4 −45
Original line number Diff line number Diff line
@@ -32,16 +32,6 @@ properties: 
      - const: core

      - const: audio



  gpio-controller: true



  "#gpio-cells":

    description: Specifying the pin number and flags, as defined in

      include/dt-bindings/gpio/gpio.h

    const: 2



  gpio-ranges:

    maxItems: 1



patternProperties:

  "-state$":

    oneOf:
@@ -57,7 +47,8 @@ $defs: 
    description:

      Pinctrl node's client devices use subnodes for desired pin configuration.

      Client device subnodes use below standard properties.

    $ref: /schemas/pinctrl/pincfg-node.yaml

    $ref: qcom,lpass-lpi-common.yaml#/$defs/qcom-tlmm-state

    unevaluatedProperties: false



    properties:

      pins:
@@ -79,48 +70,16 @@ $defs: 
          Specify the alternative function to be configured for the specified

          pins.



      drive-strength:

        enum: [2, 4, 6, 8, 10, 12, 14, 16]

        default: 2

        description:

          Selects the drive strength for the specified pins, in mA.



      slew-rate:

        enum: [0, 1, 2, 3]

        default: 0

        description: |

          0: No adjustments

          1: Higher Slew rate (faster edges)

          2: Lower Slew rate (slower edges)

          3: Reserved (No adjustments)



      bias-bus-hold: true

      bias-pull-down: true

      bias-pull-up: true

      bias-disable: true

      input-enable: true

      output-high: true

      output-low: true



    required:

      - pins

      - function



    additionalProperties: false



allOf:

  - $ref: pinctrl.yaml#

  - $ref: qcom,lpass-lpi-common.yaml#



required:

  - compatible

  - reg

  - clocks

  - clock-names

  - gpio-controller

  - "#gpio-cells"

  - gpio-ranges



additionalProperties: false

unevaluatedProperties: false



examples:

  - |

Documentation/devicetree/bindings/pinctrl/qcom,sm6115-lpass-lpi-pinctrl.yaml

+4 −44
Original line number Diff line number Diff line
@@ -31,16 +31,6 @@ properties: 
    items:

      - const: audio



  gpio-controller: true



  "#gpio-cells":

    description: Specifying the pin number and flags, as defined in

      include/dt-bindings/gpio/gpio.h

    const: 2



  gpio-ranges:

    maxItems: 1



patternProperties:

  "-state$":

    oneOf:
@@ -56,7 +46,8 @@ $defs: 
    description:

      Pinctrl node's client devices use subnodes for desired pin configuration.

      Client device subnodes use below standard properties.

    $ref: /schemas/pinctrl/pincfg-node.yaml

    $ref: qcom,lpass-lpi-common.yaml#/$defs/qcom-tlmm-state

    unevaluatedProperties: false



    properties:

      pins:
@@ -75,48 +66,17 @@ $defs: 
          Specify the alternative function to be configured for the specified

          pins.



      drive-strength:

        enum: [2, 4, 6, 8, 10, 12, 14, 16]

        default: 2

        description:

          Selects the drive strength for the specified pins, in mA.



      slew-rate:

        enum: [0, 1, 2, 3]

        default: 0

        description: |

          0: No adjustments

          1: Higher Slew rate (faster edges)

          2: Lower Slew rate (slower edges)

          3: Reserved (No adjustments)



      bias-bus-hold: true

      bias-pull-down: true

      bias-pull-up: true

      bias-disable: true

      input-enable: true

      output-high: true

      output-low: true



    required:

      - pins

      - function



    additionalProperties: false



allOf:

  - $ref: pinctrl.yaml#

  - $ref: qcom,lpass-lpi-common.yaml#



required:

  - compatible

  - reg

  - clocks

  - clock-names

  - gpio-controller

  - "#gpio-cells"

  - gpio-ranges



additionalProperties: false

unevaluatedProperties: false



examples:

  - |

Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml

+4 −45
Original line number Diff line number Diff line
@@ -30,16 +30,6 @@ properties: 
      - const: core

      - const: audio



  gpio-controller: true



  "#gpio-cells":

    description: Specifying the pin number and flags, as defined in

      include/dt-bindings/gpio/gpio.h

    const: 2



  gpio-ranges:

    maxItems: 1



patternProperties:

  "-state$":

    oneOf:
@@ -55,7 +45,8 @@ $defs: 
    description:

      Pinctrl node's client devices use subnodes for desired pin configuration.

      Client device subnodes use below standard properties.

    $ref: /schemas/pinctrl/pincfg-node.yaml

    $ref: qcom,lpass-lpi-common.yaml#/$defs/qcom-tlmm-state

    unevaluatedProperties: false



    properties:

      pins:
@@ -78,48 +69,16 @@ $defs: 
          Specify the alternative function to be configured for the specified

          pins.



      drive-strength:

        enum: [2, 4, 6, 8, 10, 12, 14, 16]

        default: 2

        description:

          Selects the drive strength for the specified pins, in mA.



      slew-rate:

        enum: [0, 1, 2, 3]

        default: 0

        description: |

            0: No adjustments

            1: Higher Slew rate (faster edges)

            2: Lower Slew rate (slower edges)

            3: Reserved (No adjustments)



      bias-pull-down: true

      bias-pull-up: true

      bias-bus-hold: true

      bias-disable: true

      input-enable: true

      output-high: true

      output-low: true



    required:

      - pins

      - function



    additionalProperties: false



allOf:

  - $ref: pinctrl.yaml#

  - $ref: qcom,lpass-lpi-common.yaml#



required:

  - compatible

  - reg

  - clocks

  - clock-names

  - gpio-controller

  - "#gpio-cells"

  - gpio-ranges



additionalProperties: false

unevaluatedProperties: false



examples:

  - |