Commit 5a6a33b5 authored by Ai Chao's avatar Ai Chao Committed by Johan Hovold
Browse files

USB: serial: ti_usb_3410_5052: use strscpy() instead of strcpy() 



Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: default avatarAi Chao <aichao@kylinos.cn>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent f338e773

drivers/usb/serial/ti_usb_3410_5052.c

+8 −8
Original line number Diff line number Diff line
@@ -1600,29 +1600,29 @@ static int ti_download_firmware(struct ti_device *tdev) 
		if (le16_to_cpu(dev->descriptor.idVendor) == MTS_VENDOR_ID) {

			switch (le16_to_cpu(dev->descriptor.idProduct)) {

			case MTS_CDMA_PRODUCT_ID:

				strcpy(buf, "mts_cdma.fw");

				strscpy(buf, "mts_cdma.fw");

				break;

			case MTS_GSM_PRODUCT_ID:

				strcpy(buf, "mts_gsm.fw");

				strscpy(buf, "mts_gsm.fw");

				break;

			case MTS_EDGE_PRODUCT_ID:

				strcpy(buf, "mts_edge.fw");

				strscpy(buf, "mts_edge.fw");

				break;

			case MTS_MT9234MU_PRODUCT_ID:

				strcpy(buf, "mts_mt9234mu.fw");

				strscpy(buf, "mts_mt9234mu.fw");

				break;

			case MTS_MT9234ZBA_PRODUCT_ID:

				strcpy(buf, "mts_mt9234zba.fw");

				strscpy(buf, "mts_mt9234zba.fw");

				break;

			case MTS_MT9234ZBAOLD_PRODUCT_ID:

				strcpy(buf, "mts_mt9234zba.fw");

				strscpy(buf, "mts_mt9234zba.fw");

				break;			}

		}

		if (buf[0] == '\0') {

			if (tdev->td_is_3410)

				strcpy(buf, "ti_3410.fw");

				strscpy(buf, "ti_3410.fw");

			else

				strcpy(buf, "ti_5052.fw");

				strscpy(buf, "ti_5052.fw");

		}

		status = request_firmware(&fw_p, buf, &dev->dev);

	}