Commit 5a856e27 authored by Raag Jadav's avatar Raag Jadav Committed by Lucas De Marchi
Browse files

drm/xe/hwmon: Drop redundant runtime PM usage 



The device is expected to be in D0 state during driver probe. No need to
resume it in ->is_visible() callbacks.

Signed-off-by: default avatarRaag Jadav <raag.jadav@intel.com>
Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Link: https://lore.kernel.org/r/20250918114804.2957177-2-raag.jadav@intel.com


Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent 20f3b28e

drivers/gpu/drm/xe/xe_hwmon.c

+0 −8
Original line number Diff line number Diff line
@@ -658,8 +658,6 @@ static umode_t xe_hwmon_attributes_visible(struct kobject *kobj, 
	struct xe_reg rapl_limit;

	struct xe_mmio *mmio = xe_root_tile_mmio(hwmon->xe);



	xe_pm_runtime_get(hwmon->xe);



	if (hwmon->xe->info.has_mbx_power_limits) {

		xe_hwmon_pcode_read_power_limit(hwmon, power_attr, channel, &uval);

	} else if (power_attr != PL2_HWMON_ATTR) {
@@ -669,8 +667,6 @@ static umode_t xe_hwmon_attributes_visible(struct kobject *kobj, 
	}

	ret = (uval & PWR_LIM_EN) ? attr->mode : 0;



	xe_pm_runtime_put(hwmon->xe);



	return ret;

}
@@ -1096,8 +1092,6 @@ xe_hwmon_is_visible(const void *drvdata, enum hwmon_sensor_types type, 
	struct xe_hwmon *hwmon = (struct xe_hwmon *)drvdata;

	int ret;



	xe_pm_runtime_get(hwmon->xe);



	switch (type) {

	case hwmon_temp:

		ret = xe_hwmon_temp_is_visible(hwmon, attr, channel);
@@ -1122,8 +1116,6 @@ xe_hwmon_is_visible(const void *drvdata, enum hwmon_sensor_types type, 
		break;

	}



	xe_pm_runtime_put(hwmon->xe);



	return ret;

}