Commit 5aa2184e authored by Yevgeny Kliteynik's avatar Yevgeny Kliteynik Committed by Paolo Abeni
Browse files

net/mlx5: HWS, fixed double free in error flow of definer layout 



Fix error flow bug that could lead to double free of a buffer
during a failure to calculate a suitable definer layout.

Fixes: 74a778b4 ("net/mlx5: HWS, added definers handling")
Signed-off-by: default avatarYevgeny Kliteynik <kliteyn@nvidia.com>
Reviewed-by: default avatarItamar Gozlan <igozlan@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 65b4eb9f

drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_definer.c

+2 −2
Original line number Diff line number Diff line
@@ -1925,7 +1925,7 @@ mlx5hws_definer_calc_layout(struct mlx5hws_context *ctx, 
	ret = hws_definer_conv_match_params_to_hl(ctx, mt, match_hl);

	if (ret) {

		mlx5hws_err(ctx, "Failed to convert items to header layout\n");

		goto free_fc;

		goto free_match_hl;

	}



	/* Find the match definer layout for header layout match union */
@@ -1946,7 +1946,7 @@ mlx5hws_definer_calc_layout(struct mlx5hws_context *ctx, 


free_fc:

	kfree(mt->fc);



free_match_hl:

	kfree(match_hl);

	return ret;

}