Commit 5abc37bd authored by Shailend Chand's avatar Shailend Chand Committed by David S. Miller
Browse files

gve: Make gve_turn(up|down) ignore stopped queues 



Currently the queues are either all live or all dead, toggling from one
state to the other via the ndo open and stop hooks. The future addition
of single-queue ndo hooks changes this, and thus gve_turnup and
gve_turndown should evolve to account for a state where some queues are
live and some aren't.

Tested-by: default avatarMina Almasry <almasrymina@google.com>
Reviewed-by: default avatarPraveen Kaligineedi <pkaligineedi@google.com>
Reviewed-by: default avatarHarshitha Ramamurthy <hramamurthy@google.com>
Signed-off-by: default avatarShailend Chand <shailend@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 242f30fe

drivers/net/ethernet/google/gve/gve_main.c

+10 −0
Original line number Diff line number Diff line
@@ -1937,12 +1937,16 @@ static void gve_turndown(struct gve_priv *priv) 
		int ntfy_idx = gve_tx_idx_to_ntfy(priv, idx);

		struct gve_notify_block *block = &priv->ntfy_blocks[ntfy_idx];



		if (!gve_tx_was_added_to_block(priv, idx))

			continue;

		napi_disable(&block->napi);

	}

	for (idx = 0; idx < priv->rx_cfg.num_queues; idx++) {

		int ntfy_idx = gve_rx_idx_to_ntfy(priv, idx);

		struct gve_notify_block *block = &priv->ntfy_blocks[ntfy_idx];



		if (!gve_rx_was_added_to_block(priv, idx))

			continue;

		napi_disable(&block->napi);

	}
@@ -1965,6 +1969,9 @@ static void gve_turnup(struct gve_priv *priv) 
		int ntfy_idx = gve_tx_idx_to_ntfy(priv, idx);

		struct gve_notify_block *block = &priv->ntfy_blocks[ntfy_idx];



		if (!gve_tx_was_added_to_block(priv, idx))

			continue;



		napi_enable(&block->napi);

		if (gve_is_gqi(priv)) {

			iowrite32be(0, gve_irq_doorbell(priv, block));
@@ -1977,6 +1984,9 @@ static void gve_turnup(struct gve_priv *priv) 
		int ntfy_idx = gve_rx_idx_to_ntfy(priv, idx);

		struct gve_notify_block *block = &priv->ntfy_blocks[ntfy_idx];



		if (!gve_rx_was_added_to_block(priv, idx))

			continue;



		napi_enable(&block->napi);

		if (gve_is_gqi(priv)) {

			iowrite32be(0, gve_irq_doorbell(priv, block));