Commit 5ac50ec7 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Lee Jones
Browse files

leds: gpio: Refactor code to use devm_gpiod_get_index_optional() 



Instead of checking for the specific error codes, replace
devm_gpiod_get_index() with devm_gpiod_get_index_optional().
In this case we just return all errors to the caller and
simply check for NULL in case if legacy GPIO is being used.
As the result the code is easier to read and maintain.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20231016161005.1471768-3-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent f5ad594e

drivers/leds/leds-gpio.c

+4 −4
Original line number Diff line number Diff line
@@ -218,13 +218,13 @@ static struct gpio_desc *gpio_led_get_gpiod(struct device *dev, int idx, 
	 * device, this will hit the board file, if any and get

	 * the GPIO from there.

	 */

	gpiod = devm_gpiod_get_index(dev, NULL, idx, GPIOD_OUT_LOW);

	if (!IS_ERR(gpiod)) {

	gpiod = devm_gpiod_get_index_optional(dev, NULL, idx, GPIOD_OUT_LOW);

	if (IS_ERR(gpiod))

		return gpiod;

	if (gpiod) {

		gpiod_set_consumer_name(gpiod, template->name);

		return gpiod;

	}

	if (PTR_ERR(gpiod) != -ENOENT)

		return gpiod;



	/*

	 * This is the legacy code path for platform code that