Commit 5ace19bd authored by Gal Pressman's avatar Gal Pressman Committed by Jakub Kicinski
Browse files

coccinelle: Add missing (GE)NL_SET_ERR_MSG_* to strings ending with newline test 



Add missing (GE)NL_SET_ERR_MSG_*() variants to the list of macros
checked for strings ending with a newline.

Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarGal Pressman <gal@nvidia.com>
Reviewed-by: default avatarMichal Swiatkowski <michal.swiatkowski@linux.intel.com>
Link: https://patch.msgid.link/20250226093904.6632-2-gal@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 38d41cf5

scripts/coccinelle/misc/newline_in_nl_msg.cocci

+8 −5
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

///

/// Catch strings ending in newline with GENL_SET_ERR_MSG, NL_SET_ERR_MSG,

/// NL_SET_ERR_MSG_MOD.

/// Catch strings ending in newline with (GE)NL_SET_ERR_MSG*.

///

// Confidence: Very High

// Copyright: (C) 2020 Intel Corporation
@@ -17,7 +16,11 @@ expression e; 
constant m;

position p;

@@

  \(GENL_SET_ERR_MSG\|NL_SET_ERR_MSG\|NL_SET_ERR_MSG_MOD\)(e,m@p)

  \(GENL_SET_ERR_MSG\|GENL_SET_ERR_MSG_FMT\|NL_SET_ERR_MSG\|NL_SET_ERR_MSG_MOD\|

  NL_SET_ERR_MSG_FMT\|NL_SET_ERR_MSG_FMT_MOD\|NL_SET_ERR_MSG_WEAK\|

  NL_SET_ERR_MSG_WEAK_MOD\|NL_SET_ERR_MSG_ATTR_POL\|

  NL_SET_ERR_MSG_ATTR_POL_FMT\|NL_SET_ERR_MSG_ATTR\|

  NL_SET_ERR_MSG_ATTR_FMT\)(e,m@p,...)



@script:python@

m << r.m;
@@ -32,7 +35,7 @@ expression r.e; 
constant r.m;

position r.p;

@@

  fname(e,m@p)

  fname(e,m@p,...)



//----------------------------------------------------------

//  For context mode
@@ -43,7 +46,7 @@ identifier r1.fname; 
expression r.e;

constant r.m;

@@

* fname(e,m)

* fname(e,m,...)



//----------------------------------------------------------

//  For org mode