Commit 5adbc8ce authored by xueqin Luo's avatar xueqin Luo Committed by Felix Fietkau
Browse files

wifi: mt76: mt7996: fix overflows seen when writing limit attributes 



DIV_ROUND_CLOSEST() after kstrtoul() results in an overflow if a large
number such as 18446744073709551615 is provided by the user.
Fix it by reordering clamp_val() and DIV_ROUND_CLOSEST() operations.
This commit was inspired by commit: 57ee12b6.

Fixes: 6879b2e9 ("wifi: mt76: mt7996: add thermal sensor device support")
Signed-off-by: default avatarxueqin Luo <luoxueqin@kylinos.cn>
Link: https://patch.msgid.link/20241202031917.23741-2-luoxueqin@kylinos.cn


Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent 113d469e

drivers/net/wireless/mediatek/mt76/mt7996/init.c

+1 −1
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ static ssize_t mt7996_thermal_temp_store(struct device *dev, 
		return ret;



	mutex_lock(&phy->dev->mt76.mutex);

	val = clamp_val(DIV_ROUND_CLOSEST(val, 1000), 40, 130);

	val = DIV_ROUND_CLOSEST(clamp_val(val, 40 * 1000, 130 * 1000), 1000);



	/* add a safety margin ~10 */

	if ((i - 1 == MT7996_CRIT_TEMP_IDX &&