Commit 5ae416c5 authored by Qasim Ijaz's avatar Qasim Ijaz Committed by Jiri Kosina
Browse files

HID: wacom: fix memory leak on kobject creation failure 



During wacom_initialize_remotes() a fifo buffer is allocated
with kfifo_alloc() and later a cleanup action is registered
during devm_add_action_or_reset() to clean it up.

However if the code fails to create a kobject and register it
with sysfs the code simply returns -ENOMEM before the cleanup
action is registered leading to a memory leak.

Fix this by ensuring the fifo is freed when the kobject creation
and registration process fails.

Fixes: 83e6b40e ("HID: wacom: EKR: have the wacom resources dynamically allocated")
Reviewed-by: default avatarPing Cheng <ping.cheng@wacom.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarQasim Ijaz <qasdev00@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 2043ae90

drivers/hid/wacom_sys.c

+3 −1
Original line number Diff line number Diff line
@@ -2048,8 +2048,10 @@ static int wacom_initialize_remotes(struct wacom *wacom) 


	remote->remote_dir = kobject_create_and_add("wacom_remote",

						    &wacom->hdev->dev.kobj);

	if (!remote->remote_dir)

	if (!remote->remote_dir) {

		kfifo_free(&remote->remote_fifo);

		return -ENOMEM;

	}



	error = sysfs_create_files(remote->remote_dir, remote_unpair_attrs);