Commit 5afe4ccc authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski
Browse files

net: dsa: tag_rtl8_4: use the dsa_xmit_port_mask() helper 



The "rtl8_4" and "rtl8_4t" tagging protocols populate a bit mask for the
TX ports, so we can use dsa_xmit_port_mask() to centralize the decision
of how to set that field.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: "Alvin Šipraga" <alsi@bang-olufsen.dk>
Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20251127120902.292555-12-vladimir.oltean@nxp.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4abf39c8

net/dsa/tag_rtl8_4.c

+1 −2
Original line number Diff line number Diff line
@@ -103,7 +103,6 @@ 
static void rtl8_4_write_tag(struct sk_buff *skb, struct net_device *dev,

			     void *tag)

{

	struct dsa_port *dp = dsa_user_to_port(dev);

	__be16 tag16[RTL8_4_TAG_LEN / 2];



	/* Set Realtek EtherType */
@@ -116,7 +115,7 @@ static void rtl8_4_write_tag(struct sk_buff *skb, struct net_device *dev, 
	tag16[2] = htons(FIELD_PREP(RTL8_4_LEARN_DIS, 1));



	/* Zero ALLOW; set RX (CPU->switch) forwarding port mask */

	tag16[3] = htons(FIELD_PREP(RTL8_4_RX, BIT(dp->index)));

	tag16[3] = htons(FIELD_PREP(RTL8_4_RX, dsa_xmit_port_mask(skb, dev)));



	memcpy(tag, tag16, RTL8_4_TAG_LEN);

}