Commit 5b440a8b authored by Colin Ian King's avatar Colin Ian King Committed by Lucas De Marchi
Browse files

drm/xe/xe_late_bind_fw: Fix missing initialization of variable offset 



The variable offset is not being initialized, and it is only set inside
a for-loop if entry->name is the same as manifest_entry. In the case
where it is not initialized a non-zero check on offset is potentialy checking
a bogus uninitalized value. Fix this by initializing offset to zero.

Fixes: efa29317 ("drm/xe/xe_late_bind_fw: Extract and print version info")
Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Reviewed-by: default avatarBadal Nilawar <badal.nilawar@intel.com>
Reviewed-by: default avatarJonathan Cavitt <jonathan.cavitt@intel.com>
Link: https://lore.kernel.org/r/20250924102208.9216-1-colin.i.king@gmail.com


Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit 20f3b28e)
Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent 17f6f6f2

drivers/gpu/drm/xe/xe_late_bind_fw.c

+2 −2
Original line number Diff line number Diff line
@@ -60,7 +60,7 @@ static int parse_cpd_header(struct xe_late_bind_fw *lb_fw, 
	const struct gsc_manifest_header *manifest;

	const struct gsc_cpd_entry *entry;

	size_t min_size = sizeof(*header);

	u32 offset;

	u32 offset = 0;

	int i;



	/* manifest_entry is mandatory */
@@ -116,7 +116,7 @@ static int parse_lb_layout(struct xe_late_bind_fw *lb_fw, 
	const struct csc_fpt_header *header = data;

	const struct csc_fpt_entry *entry;

	size_t min_size = sizeof(*header);

	u32 offset;

	u32 offset = 0;

	int i;



	/* fpt_entry is mandatory */