Commit 5b6179d4 authored by Karan Tilak Kumar's avatar Karan Tilak Kumar Committed by Martin K. Petersen
Browse files

scsi: fnic: Remove unnecessary else and unnecessary break in FDLS 



Incorporate review comments from Martin:
    Remove unnecessary else and unnecessary break to fix warnings
    in the FDLS code.

Reviewed-by: default avatarSesidhar Baddela <sebaddel@cisco.com>
Reviewed-by: default avatarArulprabhu Ponnusamy <arulponn@cisco.com>
Reviewed-by: default avatarGian Carlo Boffa <gcboffa@cisco.com>
Reviewed-by: default avatarArun Easi <aeasi@cisco.com>
Signed-off-by: default avatarKaran Tilak Kumar <kartilak@cisco.com>
Link: https://lore.kernel.org/r/20250106224451.3597-1-kartilak@cisco.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 8f22f904

drivers/scsi/fnic/fdls_disc.c

+6 −10
Original line number Diff line number Diff line
@@ -2776,7 +2776,7 @@ fdls_process_tgt_prli_rsp(struct fnic_iport_s *iport, 
			/*Retry Plogi again from the timer routine. */

			tport->flags |= FNIC_FDLS_RETRY_FRAME;

			return;

		} else {

		}

		FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,

					 "PRLI returned ELS_LS_RJT from target: 0x%x",

					 tgt_fcid);
@@ -2784,15 +2784,11 @@ fdls_process_tgt_prli_rsp(struct fnic_iport_s *iport, 
		fdls_tgt_logout(iport, tport);

		fdls_delete_tport(iport, tport);

		return;

		}

		break;



	default:

		atomic64_inc(&iport->iport_stats.tport_prli_misc_rejects);

		FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,

					 "PRLI not accepted from target: 0x%x", tgt_fcid);

		return;

		break;

	}



	FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,