Unverified Commit 5b838a24 authored by Stephen Rothwell's avatar Stephen Rothwell Committed by Mark Brown
Browse files

ASoC: SDCA: Check devm_mutex_init() return value



Fix interaction with commit daec29dc ("locking/mutex: Mark
devm_mutex_init() as __must_check"), add return value check. There is no
need for additional complex error handling here, failure to init the
mutex means the code can't progress, so the failure just needs to be passed
up to the caller.

Fixes: b126394d ("ASoC: SDCA: Generic interrupt support")
Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20250722102754.2514351-1-ckeepax@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 17882721
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -419,7 +419,9 @@ struct sdca_interrupt_info *sdca_irq_allocate(struct device *dev,

	info->irq_chip = sdca_irq_chip;

	devm_mutex_init(dev, &info->irq_lock);
	ret = devm_mutex_init(dev, &info->irq_lock);
	if (ret)
		return ERR_PTR(ret);

	ret = devm_regmap_add_irq_chip(dev, regmap, irq, IRQF_ONESHOT, 0,
				       &info->irq_chip, &info->irq_data);