Commit 5b9481a4 authored by Jorge Marques's avatar Jorge Marques Committed by Alexandre Belloni
Browse files

i3c: master: Remove i3c_device_free_ibi from i3c_device_remove 



i3c_device_disable_ibi should be called before i3c_device_free_ibi,
however, a driver using devm actions cannot yield the call before the
bus_type.remove(), requiring to use a .remove method that is usually
discouraged for drivers that uses resources already manage. Since the
only consumer mctp-i3c.c of this method calls both
i3c_device_disable_ibi then i3c_device_free_ibi, remove the call from
the i3c_device_remove (bus_type.remove()).

Signed-off-by: default avatarJorge Marques <jorge.marques@analog.com>
Link: https://patch.msgid.link/20251112-ibi-unsafe-v1-1-d8454db22613@analog.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent a54b1aeb

drivers/i3c/master.c

+0 −2
Original line number Diff line number Diff line
@@ -334,8 +334,6 @@ static void i3c_device_remove(struct device *dev) 


	if (driver->remove)

		driver->remove(i3cdev);



	i3c_device_free_ibi(i3cdev);

}



const struct bus_type i3c_bus_type = {