Unverified Commit 5bd56670 authored by Umesh Nerlige Ramappa's avatar Umesh Nerlige Ramappa Committed by Rodrigo Vivi
Browse files

drm/xe/oa: Allow oa_exponent value of 0 



OA exponent value of 0 is a valid value for periodic reports. Allow user
to pass 0 for the OA sampling interval since it gets converted to 2 gt
clock ticks.

v2: Update the check in xe_oa_stream_init as well (Ashutosh)
v3: Fix mi-rpc failure by setting default exponent to -1 (CI)
v4: Add the Fixes tag

Fixes: b6fd51c6 ("drm/xe/oa/uapi: Define and parse OA stream properties")
Signed-off-by: default avatarUmesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Reviewed-by: default avatarAshutosh Dixit <ashutosh.dixit@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250221213352.1712932-1-umesh.nerlige.ramappa@intel.com


(cherry picked from commit 30341f0b)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent a9f4fa3a

drivers/gpu/drm/xe/xe_oa.c

+3 −2
Original line number Diff line number Diff line
@@ -1689,7 +1689,7 @@ static int xe_oa_stream_init(struct xe_oa_stream *stream, 
	stream->oa_buffer.format = &stream->oa->oa_formats[param->oa_format];



	stream->sample = param->sample;

	stream->periodic = param->period_exponent > 0;

	stream->periodic = param->period_exponent >= 0;

	stream->period_exponent = param->period_exponent;

	stream->no_preempt = param->no_preempt;

	stream->wait_num_reports = param->wait_num_reports;
@@ -1970,6 +1970,7 @@ int xe_oa_stream_open_ioctl(struct drm_device *dev, u64 data, struct drm_file *f 
	}



	param.xef = xef;

	param.period_exponent = -1;

	ret = xe_oa_user_extensions(oa, XE_OA_USER_EXTN_FROM_OPEN, data, 0, &param);

	if (ret)

		return ret;
@@ -2024,7 +2025,7 @@ int xe_oa_stream_open_ioctl(struct drm_device *dev, u64 data, struct drm_file *f 
		goto err_exec_q;

	}



	if (param.period_exponent > 0) {

	if (param.period_exponent >= 0) {

		u64 oa_period, oa_freq_hz;



		/* Requesting samples from OAG buffer is a privileged operation */