Commit 5bd88fef authored by Thorsten Blum's avatar Thorsten Blum Committed by Andrew Morton
Browse files

mm/memfd: replace deprecated strcpy() with memcpy() in alloc_name() 

strcpy() is deprecated; use memcpy() instead.

Not copying the NUL terminator is safe because strncpy_from_user() would
overwrite it anyway by appending uname to the destination buffer at index
MFD_NAME_PREFIX_LEN.

No functional changes intended.

Link: https://github.com/KSPP/linux/issues/88
Link: https://lkml.kernel.org/r/20250712174516.64243-2-thorsten.blum@linux.dev


Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Hugh Dickins <hughd@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 5add26c0

mm/memfd.c

+1 −1
Original line number Diff line number Diff line
@@ -411,7 +411,7 @@ static char *alloc_name(const char __user *uname) 
	if (!name)

		return ERR_PTR(-ENOMEM);



	strcpy(name, MFD_NAME_PREFIX);

	memcpy(name, MFD_NAME_PREFIX, MFD_NAME_PREFIX_LEN);

	/* returned length does not include terminating zero */

	len = strncpy_from_user(&name[MFD_NAME_PREFIX_LEN], uname, MFD_NAME_MAX_LEN + 1);

	if (len < 0) {