Commit 5bf763e9 authored by Ashutosh Dixit's avatar Ashutosh Dixit
Browse files

drm/xe/eustall: Disallow 0 EU stall property values 



An EU stall property value of 0 is invalid and will cause a NPD.

Reported-by: default avatarPeter Senna Tschudin <peter.senna@linux.intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/6453


Fixes: 1537ec85 ("drm/xe/uapi: Introduce API for EU stall sampling")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarAshutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: default avatarHarish Chegondi <harish.chegondi@intel.com>
Link: https://patch.msgid.link/20251212061850.1565459-4-ashutosh.dixit@intel.com
parent 7a100e6d

drivers/gpu/drm/xe/xe_eu_stall.c

+1 −1
Original line number Diff line number Diff line
@@ -315,7 +315,7 @@ static int xe_eu_stall_user_ext_set_property(struct xe_device *xe, u64 extension 
		return -EFAULT;



	if (XE_IOCTL_DBG(xe, ext.property >= ARRAY_SIZE(xe_set_eu_stall_property_funcs)) ||

	    XE_IOCTL_DBG(xe, ext.pad))

	    XE_IOCTL_DBG(xe, !ext.property) || XE_IOCTL_DBG(xe, ext.pad))

		return -EINVAL;



	idx = array_index_nospec(ext.property, ARRAY_SIZE(xe_set_eu_stall_property_funcs));